tillrohrmann commented on a change in pull request #14666:
URL: https://github.com/apache/flink/pull/14666#discussion_r559422674
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterDescriptor.java
##########
@@ -118,7 +118,7 @@ public String getClusterDescription() {
HighAvailabilityServicesUtils.AddressResolution
.TRY_ADDRESS_RESOLUTION)));
} catch (Exception e) {
- client.handleException(e);
+ LOG.error("An exception occurred while instantiating the
RestClusterClient.", e);
Review comment:
Hmm, maybe it was the intention to suppress all exceptions while the
`LocalExecutor` is being shut down. Also, shouldn't the main thread log an
uncaught exception? And if not, then we should probably add it there because
who knows which other components follow the pattern to let exceptions bubble up
to a point where they can be treated w/o logging it on the way.
The problem with logging exceptions at several places is that the logs
become harder to understand/read.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
