XComp commented on a change in pull request #14666:
URL: https://github.com/apache/flink/pull/14666#discussion_r558501302
##########
File path:
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/KubernetesClusterDescriptor.java
##########
@@ -118,7 +118,7 @@ public String getClusterDescription() {
HighAvailabilityServicesUtils.AddressResolution
.TRY_ADDRESS_RESOLUTION)));
} catch (Exception e) {
- client.handleException(e);
+ LOG.error("An exception occurred while instantiating the
RestClusterClient.", e);
Review comment:
I thought so, too. But some call paths end up forwarding the
`RuntimeException` up to the `main` method without any logging. Some paths
swallowed the final exception without any logging (happened during
closing/cancellation procedures like
[LocalExecutor.closeSession(..)](https://github.com/apache/flink/blob/c6997c97c575d334679915c328792b8a3067cfb5/flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java#L239)).
Hence, I stepped back from this approach and went for the safer option of
logging it as it was discussed in the [initial PR
discussion](https://github.com/apache/flink/pull/11427#discussion_r404221581).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
