wuchong commented on a change in pull request #14720:
URL: https://github.com/apache/flink/pull/14720#discussion_r562006158
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/generated/CompileUtils.java
##########
@@ -62,7 +62,7 @@
try {
Cache<ClassLoader, Class> compiledClasses =
COMPILED_CACHE.get(
- name,
+ name + code,
Review comment:
If we want to take code into account, we only need to use code as the
key, because code already include the class name. This can avoid creating a new
String as the code may be very big.
Would be better to add a comment above this to explain why we use code
instead of name as the cache key.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
