twalthr commented on a change in pull request #14720:
URL: https://github.com/apache/flink/pull/14720#discussion_r562040976
##########
File path:
flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/generated/CompileUtils.java
##########
@@ -62,7 +62,7 @@
try {
Cache<ClassLoader, Class> compiledClasses =
COMPILED_CACHE.get(
- name,
+ name + code,
Review comment:
I think the runtime overhead is neglectable because we are not in the
hotpath but pre-flight phase. But sure, code as a key should be sufficient. I
will adapt the PR and add a comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
