pnowojski commented on pull request #7: URL: https://github.com/apache/flink-benchmarks/pull/7#issuecomment-765555797
Thanks for the changes @Thesharing. I haven't looked at the code at benchmarks, so it would be great if for example @zhuzhurk could review this. Besides that, the remaining thing to do is: > 4. I think those coordinator benchmarks should be setup as independent benchmark run, the same way how statebackend benchmarks are executed. Statebackend have their own profile in the pom.xml and they are not executed together with the main runtime benchmarks. Also in the jenkins http://codespeed.dak8s.net:8080/ we have different cron jobs for runtime and statebackend. All of this is in order to speed up response to a question "I've made some change and I want to check the benchmark results". Runtime changes shouldn't affect coordinator benchmarks and vice versa, so there is no point in waiting for coordinator benchmarks after making runtime changes :) So the `pom.xml` should be adjusted and and later we need to update/setup Jenkins accordingly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
