[ 
https://issues.apache.org/jira/browse/FLINK-3639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207254#comment-15207254
 ] 

ASF GitHub Bot commented on FLINK-3639:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1827#discussion_r57065169
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/FlinkRuleSets.scala
 ---
    @@ -93,7 +93,10 @@ object FlinkRuleSets {
         DataSetCalcRule.INSTANCE,
         DataSetJoinRule.INSTANCE,
         DataSetScanRule.INSTANCE,
    -    DataSetUnionRule.INSTANCE
    +    DataSetUnionRule.INSTANCE,
    +
    +    // convert a logical table scan to a relational expression
    +    TableScanRule.INSTANCE
    --- End diff --
    
    Can we move this rule to the top to the other default Calcite rules?


> Add methods and utilities to register DataSets and Tables in the 
> TableEnvironment
> ---------------------------------------------------------------------------------
>
>                 Key: FLINK-3639
>                 URL: https://issues.apache.org/jira/browse/FLINK-3639
>             Project: Flink
>          Issue Type: New Feature
>          Components: Table API
>    Affects Versions: 1.1.0
>            Reporter: Vasia Kalavri
>            Assignee: Vasia Kalavri
>
> In order to make tables queryable from SQL we need to register them under a 
> unique name in the TableEnvironment.
> [This design 
> document|https://docs.google.com/document/d/1sITIShmJMGegzAjGqFuwiN_iw1urwykKsLiacokxSw0/edit]
>  describes the proposed API.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to