[
https://issues.apache.org/jira/browse/FLINK-3639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207306#comment-15207306
]
ASF GitHub Bot commented on FLINK-3639:
---------------------------------------
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1827#issuecomment-200025666
Thanks for the PR! Looks good overall.
I think we can save a few LOCs by refactoring common parts a bit. Also I
spotted more opportunities to use Scala's String building feature (`s""`) which
is nicer than String concatenation, IMO.
> Add methods and utilities to register DataSets and Tables in the
> TableEnvironment
> ---------------------------------------------------------------------------------
>
> Key: FLINK-3639
> URL: https://issues.apache.org/jira/browse/FLINK-3639
> Project: Flink
> Issue Type: New Feature
> Components: Table API
> Affects Versions: 1.1.0
> Reporter: Vasia Kalavri
> Assignee: Vasia Kalavri
>
> In order to make tables queryable from SQL we need to register them under a
> unique name in the TableEnvironment.
> [This design
> document|https://docs.google.com/document/d/1sITIShmJMGegzAjGqFuwiN_iw1urwykKsLiacokxSw0/edit]
> describes the proposed API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
