[ 
https://issues.apache.org/jira/browse/FLINK-3657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15208060#comment-15208060
 ] 

ASF GitHub Bot commented on FLINK-3657:
---------------------------------------

Github user fhueske commented on the pull request:

    https://github.com/apache/flink/pull/1829#issuecomment-200244139
  
    I'm not sure if it is too specific. The fact that somebody reimplemented 
the functionality hints that it might be useful. 
    However, the name would need to be changed to something like 
`countElementsPerPartition()`, IMO.


> Change access of DataSetUtils.countElements() to 'public' 
> ----------------------------------------------------------
>
>                 Key: FLINK-3657
>                 URL: https://issues.apache.org/jira/browse/FLINK-3657
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataSet API
>    Affects Versions: 1.0.0
>            Reporter: Suneel Marthi
>            Assignee: Suneel Marthi
>            Priority: Minor
>             Fix For: 1.0.1
>
>
> The access of DatasetUtils.countElements() is presently 'private', change 
> that to be 'public'. We happened to be replicating the functionality in our 
> project and realized the method already existed in Flink.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to