[
https://issues.apache.org/jira/browse/FLINK-3657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212547#comment-15212547
]
ASF GitHub Bot commented on FLINK-3657:
---------------------------------------
Github user hsaputra commented on the pull request:
https://github.com/apache/flink/pull/1829#issuecomment-201567738
If it is on the Dataset or any extendible public APIs, I would be worried.
The change was to expose private to public without modifying existing behavior.
Would be ok from my side.
> Change access of DataSetUtils.countElements() to 'public'
> ----------------------------------------------------------
>
> Key: FLINK-3657
> URL: https://issues.apache.org/jira/browse/FLINK-3657
> Project: Flink
> Issue Type: Improvement
> Components: DataSet API
> Affects Versions: 1.0.0
> Reporter: Suneel Marthi
> Assignee: Suneel Marthi
> Priority: Minor
> Fix For: 1.0.1
>
>
> The access of DatasetUtils.countElements() is presently 'private', change
> that to be 'public'. We happened to be replicating the functionality in our
> project and realized the method already existed in Flink.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
