[
https://issues.apache.org/jira/browse/FLINK-3639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15208588#comment-15208588
]
ASF GitHub Bot commented on FLINK-3639:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1827#discussion_r57178675
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/TranslationContext.scala
---
@@ -59,29 +64,48 @@ object TranslationContext {
.traitDefs(ConventionTraitDef.INSTANCE)
.build
- tabNames = Map[AbstractTable, String]()
-
+ tablesRegistry = Map[String, AbstractTable]()
relBuilder = RelBuilder.create(frameworkConfig)
-
nameCntr.set(0)
}
+ /**
+ * Adds a table to the Calcite schema so it can be used by the Table API
+ */
def addDataSet(newTable: DataSetTable[_]): String = {
+ val tabName = "DataSetTable_" + nameCntr.getAndIncrement()
+ tables.add(tabName, newTable)
+ tabName
+ }
+
+ /**
+ * Adds a table to the Calcite schema and the tables registry,
+ * so it can be used by both Table API and SQL statements.
+ */
+ @throws[TableException]
+ def registerTable(table: AbstractTable, name: String): Unit = {
- // look up name
- val tabName = tabNames.get(newTable)
+ val existingTable = tablesRegistry.get(name)
--- End diff --
Should we check that the name does not follow the pattern
`DataSetTable_[0-9]+`?
> Add methods and utilities to register DataSets and Tables in the
> TableEnvironment
> ---------------------------------------------------------------------------------
>
> Key: FLINK-3639
> URL: https://issues.apache.org/jira/browse/FLINK-3639
> Project: Flink
> Issue Type: New Feature
> Components: Table API
> Affects Versions: 1.1.0
> Reporter: Vasia Kalavri
> Assignee: Vasia Kalavri
>
> In order to make tables queryable from SQL we need to register them under a
> unique name in the TableEnvironment.
> [This design
> document|https://docs.google.com/document/d/1sITIShmJMGegzAjGqFuwiN_iw1urwykKsLiacokxSw0/edit]
> describes the proposed API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
