XComp commented on a change in pull request #14798:
URL: https://github.com/apache/flink/pull/14798#discussion_r567421044
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/DefaultScheduler.java
##########
@@ -267,9 +267,16 @@ private void restartTasksWithDelay(final
FailureHandlingResult failureHandlingRe
delayExecutor.schedule(
() ->
FutureUtils.assertNoException(
- cancelFuture.thenRunAsync(
- restartTasks(executionVertexVersions,
globalRecovery),
- getMainThreadExecutor())),
+ cancelFuture
+ .thenRunAsync(
+ () ->
+
archiveFromFailureHandlingResult(
+
failureHandlingResult),
+ getMainThreadExecutor())
+ .thenRunAsync(
+ restartTasks(
+
executionVertexVersions, globalRecovery),
+ getMainThreadExecutor())),
Review comment:
That's a good question. I did it when experimenting for convenience and
didn't reiterate over it again. 👍 I refactored it now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
