XComp commented on a change in pull request #14798:
URL: https://github.com/apache/flink/pull/14798#discussion_r567418341
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SchedulerBase.java
##########
@@ -641,6 +648,33 @@ public void cancel() {
return
executionGraph.getTerminationFuture().thenApply(FunctionUtils.nullFn());
}
+ protected void archiveGlobalFailure(Throwable failure) {
+ Set<ExecutionAttemptID> executionAttemptIds =
+
IterableUtils.toStream(executionGraph.getAllExecutionVertices())
+ .map(ExecutionVertex::getCurrentExecutionAttempt)
+ .map(Execution::getAttemptId)
+ .collect(Collectors.toSet());
+
+ globalTaskFailures.put(
+ executionAttemptIds, new ErrorInfo(failure,
System.currentTimeMillis()));
+
+ log.debug("Archive global {}: {}", failure, failure.getMessage());
+ }
+
+ protected void archiveFromFailureHandlingResult(FailureHandlingResult
failureHandlingResult) {
+ if (failureHandlingResult.getExecutionVertexIdOfFailedTask() == null) {
Review comment:
I removed this check. This if was a relict from a previous code version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
