pnowojski opened a new pull request #14828:
URL: https://github.com/apache/flink/pull/14828
Previously there were two issues:
1. Original failure reason would be hidden and replaced with
CHECKPOINT_ASYNC_EXCEPTION
2. The order of cancelling AsyncCheckpointRunnable and notifing the JM was
sub-optimal.
Instead of notifing the JM first, we were first cancelling the future,
which could
create a race condition, were the secondary failure was reported first,
causing
slightly less readable logs/error messages.
## Verifying this change
Added unit test.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (**yes** / no /
don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
