Myasuka commented on a change in pull request #14828:
URL: https://github.com/apache/flink/pull/14828#discussion_r567772897
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/checkpointing/SingleCheckpointBarrierHandler.java
##########
@@ -257,8 +257,8 @@ private void abortInternal(long cancelledId,
CheckpointException exception) thro
Math.max(lastCancelledOrCompletedCheckpointId, cancelledId);
numBarriersReceived = 0;
controller.abortPendingCheckpoint(cancelledId, exception);
- allBarriersReceivedFuture.completeExceptionally(exception);
notifyAbort(cancelledId, exception);
+ allBarriersReceivedFuture.completeExceptionally(exception);
Review comment:
I think this line change should be in another commit compared with below
changes to ensure exception is not overridden by `CHECKPOINT_ASYNC_EXCEPTION`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
