gaoyunhaii commented on a change in pull request #14820:
URL: https://github.com/apache/flink/pull/14820#discussion_r570018055
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -877,12 +875,6 @@ public StreamStatusMaintainer getStreamStatusMaintainer() {
CompletableFuture<Boolean> result = new CompletableFuture<>();
mainMailboxExecutor.execute(
() -> {
- latestAsyncCheckpointStartDelayNanos =
Review comment:
This variable is only used for the true source tasks which do not
attached with a `CheckpointBarrierHandler`, thus initially I think it could be
moved to the base class for the source tasks would make it more clear.
The variable mainly measures the delay between JM triggering checkpoint and
(source) tasks start to processing this checkpoint (namely
`checkpointStartDelayNanos`), since move it to be inside `triggerCheckpoint`
would only differs in the time of one method call, thus I think it would not
cause too large difference, and we could rename the variable to
`latestACheckpointStartDelayNanos`. Do you think this option would also be ok?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
