gaoyunhaii commented on a change in pull request #14820:
URL: https://github.com/apache/flink/pull/14820#discussion_r570028569
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
##########
@@ -901,54 +893,12 @@ public StreamStatusMaintainer getStreamStatusMaintainer()
{
return result;
}
- private boolean triggerCheckpoint(
+ protected boolean triggerCheckpoint(
Review comment:
Currently not making it abstract is mainly because
`MultipleInputStreamTask` has override `triggerCheckpointAsync`, if we make `
triggerCheckpoint` abstract, then it has implemented an empty method which it
does not use. If we want to also make `MultipleInputStreamTask` do not need to
override `triggerCheckpointAsync` directly, we have to make the completable
future a parameter to `triggerCheckpoint` and let the triggerCheckpoint to
complete the future instead of hide it from `triggerCheckpoint`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
