LadyForest opened a new pull request #14877:
URL: https://github.com/apache/flink/pull/14877
## Contribution Checklist
## What is the purpose of the change
* This pull request tries to support OVER window distinct aggregates in
`OverConverterRule`. Currently, `OverConvertRule` always sets the distinct flag
to false, and could not make rex call for an `agg` expression's children
expression like `distinct(avg/count/sum(field))`, thus cause
`ExpressionConverter#visit` throwing `RuntimeException` that "`Unknown call
expression: avg(field)`".
## Brief change log
- *The changes applied to `OverConverterRule` add a flag `isDistinct` by
checking the function definition of `DISTINCT` and using inner agg expression
to generate RexNode if `isDistinct` is true.*
## Verifying this change
This change added tests and can be verified as follows:
- *`OverAggregateTest#testRowTimeBoundedDistinctWithPartitionedRangeOver`,
`OverAggregateTest#testRowTimeUnboundedDistinctWithPartitionedRangeOver`,
`OverAggregateTest#testRowTimeBoundedDistinctWithPartitionedRowsOver` and
`OverAggregateTest#testRowTimeUnboundedDistinctWithPartitionedRowsOver` are to
verify the optimized plan.*
-
*`OverAggregateITCase#testRowTimeBoundedDistinctWithPartitionedRangeOver`,
`OverAggregateITCase#testRowTimeUnboundedDistinctWithPartitionedRangeOver`,
`OverAggregateITCase#testRowTimeBoundedDistinctWithPartitionedRowsOver` and
`OverAggregateITCase#testRowTimeUnboundedDistinctWithPartitionedRowsOver` are
to verify the execution result.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no**
/ don't know)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** /
don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs /
JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
