[
https://issues.apache.org/jira/browse/FLINK-3579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15217543#comment-15217543
]
ASF GitHub Bot commented on FLINK-3579:
---------------------------------------
Github user ramkrish86 commented on a diff in the pull request:
https://github.com/apache/flink/pull/1821#discussion_r57844716
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/RexNodeTranslator.scala
---
@@ -134,7 +136,13 @@ object RexNodeTranslator {
case Plus(left, right) =>
val l = toRexNode(left, relBuilder)
val r = toRexNode(right, relBuilder)
- relBuilder.call(SqlStdOperatorTable.PLUS, l, r)
+ if(SqlTypeName.STRING_TYPES.contains(l.getType.getSqlTypeName)) {
--- End diff --
Valid point. I thought of handling both sides. Let me check this.
> Improve String concatenation
> ----------------------------
>
> Key: FLINK-3579
> URL: https://issues.apache.org/jira/browse/FLINK-3579
> Project: Flink
> Issue Type: Bug
> Components: Table API
> Reporter: Timo Walther
> Assignee: ramkrishna.s.vasudevan
> Priority: Minor
>
> Concatenation of a String and non-String does not work properly.
> e.g. {{f0 + 42}} leads to RelBuilder Exception
> ExpressionParser does not like {{f0 + 42.cast(STRING)}} either.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
