[
https://issues.apache.org/jira/browse/FLINK-3579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15218019#comment-15218019
]
ASF GitHub Bot commented on FLINK-3579:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1821#discussion_r57896311
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/expressions/ExpressionParser.scala
---
@@ -59,6 +59,8 @@ object ExpressionParser extends JavaTokenParsers with
PackratParsers {
Literal(str.toInt)
} else if (str.endsWith("f") | str.endsWith("F")) {
Literal(str.toFloat)
+ } else if (str.endsWith(".")) {
--- End diff --
Seems a little bit like a hack to me. Ideally, you should design your
grammar such that you won't see the token `1.` if it is not a valid number
expression.
> Improve String concatenation
> ----------------------------
>
> Key: FLINK-3579
> URL: https://issues.apache.org/jira/browse/FLINK-3579
> Project: Flink
> Issue Type: Bug
> Components: Table API
> Reporter: Timo Walther
> Assignee: ramkrishna.s.vasudevan
> Priority: Minor
>
> Concatenation of a String and non-String does not work properly.
> e.g. {{f0 + 42}} leads to RelBuilder Exception
> ExpressionParser does not like {{f0 + 42.cast(STRING)}} either.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
