wangyang0918 commented on pull request #14891: URL: https://github.com/apache/flink/pull/14891#issuecomment-775610643
@PChou What I mean is adding a private method `ClassPathPackagedProgramRetriever#buildUserClassPaths`. It will be used to initialize the `userClassPaths` variable in constructor. Do we have some situations that the `pipeline.classpaths` should not be added to the user classpaths? If not, then I think merging the `pipeline.classpaths` and `usrlib` internally in `ClassPathPackagedProgramRetriever` is reasonable. BTW, based on your current implementation, the `StandaloneApplicationClusterEntryPoint` also needs to set the pipeline classpath. > When "other mode" access the ClassPathPackagedProgramRetriever, pipelineClassPath is empty collection by default, that will not affect the mode's behavior So do you mean in "other mode", we do not need to set the pipeline classpaths? I am afraid I cannot agree with you. The `ClassPathPackagedProgramRetriever` always should set the pipeline classpaths. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
