[ 
https://issues.apache.org/jira/browse/FLINK-3665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222856#comment-15222856
 ] 

ASF GitHub Bot commented on FLINK-3665:
---------------------------------------

GitHub user dawidwys opened a pull request:

    https://github.com/apache/flink/pull/1848

    [FLINK-3665] Implemented sort orders support in range partitioning

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dawidwys/flink withOrders

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1848.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1848
    
----
commit bbb46d6fc7c555ba458cb129805ca323ccc8e2d2
Author: dawid <[email protected]>
Date:   2016-04-02T11:10:59Z

    [FLINK-3665] Implemented sort orders support in range partitioning

commit bdbaf8ab9dda530128fd92193c08ddc31b91b4a8
Author: dawid <[email protected]>
Date:   2016-04-02T11:15:29Z

    Removed unnecessary code

----


> Range partitioning lacks support to define sort orders
> ------------------------------------------------------
>
>                 Key: FLINK-3665
>                 URL: https://issues.apache.org/jira/browse/FLINK-3665
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataSet API
>    Affects Versions: 1.0.0
>            Reporter: Fabian Hueske
>             Fix For: 1.1.0
>
>
> {{DataSet.partitionByRange()}} does not allow to specify the sort order of 
> fields. This is fine if range partitioning is used to reduce skewed 
> partitioning. 
> However, it is not sufficient if range partitioning is used to sort a data 
> set in parallel. 
> Since {{DataSet.partitionByRange()}} is {{@Public}} API and cannot be easily 
> changed, I propose to add a method {{withOrders(Order... orders)}} to 
> {{PartitionOperator}}. The method should throw an exception if the 
> partitioning method of {{PartitionOperator}} is not range partitioning.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to