[
https://issues.apache.org/jira/browse/FLINK-3665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15234787#comment-15234787
]
ASF GitHub Bot commented on FLINK-3665:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1848#discussion_r59176476
--- Diff:
flink-java/src/main/java/org/apache/flink/api/java/operators/PartitionOperator.java
---
@@ -98,6 +101,14 @@ public PartitionOperator(DataSet<T> input, Keys<T>
pKeys, Partitioner<?> customP
this.customPartitioner = customPartitioner;
this.distribution = distribution;
}
+
+ public PartitionOperator<T> withOrders(Order... orders) {
--- End diff --
The output of `ek.getOriginalKeyFieldTypes` should be:
`TypeInformation[] {TypeInformation<Pojo1>, TypeInformation<Integer>}`.
So the composite type `Pojo1` should not be flattened into its components,
i.e., `(String, String)`. This is important, because a user would only specify
two orders (one for each key expression) and the first one needs to applied to
all flat keys of `Pojo1`.
> Range partitioning lacks support to define sort orders
> ------------------------------------------------------
>
> Key: FLINK-3665
> URL: https://issues.apache.org/jira/browse/FLINK-3665
> Project: Flink
> Issue Type: Improvement
> Components: DataSet API
> Affects Versions: 1.0.0
> Reporter: Fabian Hueske
> Fix For: 1.1.0
>
>
> {{DataSet.partitionByRange()}} does not allow to specify the sort order of
> fields. This is fine if range partitioning is used to reduce skewed
> partitioning.
> However, it is not sufficient if range partitioning is used to sort a data
> set in parallel.
> Since {{DataSet.partitionByRange()}} is {{@Public}} API and cannot be easily
> changed, I propose to add a method {{withOrders(Order... orders)}} to
> {{PartitionOperator}}. The method should throw an exception if the
> partitioning method of {{PartitionOperator}} is not range partitioning.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
