wangyang0918 commented on a change in pull request #15052:
URL: https://github.com/apache/flink/pull/15052#discussion_r585398460



##########
File path: 
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/utils/KubernetesUtils.java
##########
@@ -83,6 +85,8 @@
 
     private static final Logger LOG = 
LoggerFactory.getLogger(KubernetesUtils.class);
 
+    private static final YAMLMapper yamlMapper = new YAMLMapper();

Review comment:
       You are right. The `jackson` dependency is pulled in via 
`io.fabric8:kubernetes-client`. And we have shaded these classes in 
`maven-shade-plugin`. 
   
   I also hesitated to directly rely on the transitive dependencies. Compared 
with explicitly adding the dependency, I prefer to rely on the shaded jackson.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to