tillrohrmann commented on a change in pull request #15052:
URL: https://github.com/apache/flink/pull/15052#discussion_r585477393



##########
File path: 
flink-kubernetes/src/main/java/org/apache/flink/kubernetes/utils/KubernetesUtils.java
##########
@@ -83,6 +85,8 @@
 
     private static final Logger LOG = 
LoggerFactory.getLogger(KubernetesUtils.class);
 
+    private static final YAMLMapper yamlMapper = new YAMLMapper();

Review comment:
       I think we should still add the `flink-shaded-jackson` dependency 
explicitly to the `pom.xml` of the `flink-kubernetes` module because otherwise 
it is not self-contained. What we can do is to add
   
   ```
   <dependency>
        <groupId>org.apache.flink</groupId>
        <artifactId>flink-shaded-jackson</artifactId>
        <scope>provided</scope>
   </dependency>
   ```
   
   which says that some other component needs to provide this dependency. But 
it states that this component needs this dependency in order to work.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to