anlen321 commented on a change in pull request #14684:
URL: https://github.com/apache/flink/pull/14684#discussion_r587463451



##########
File path: 
flink-connectors/flink-connector-hbase-base/src/main/java/org/apache/flink/connector/hbase/util/HBaseSerde.java
##########
@@ -225,6 +217,13 @@ public Get createGet(Object rowKey) {
 
     /** Converts HBase {@link Result} into {@link RowData}. */
     public RowData convertToRow(Result result) {
+        // The output rows needs to be initialized each time

Review comment:
       @leonardBang  Sounds good. I think if we add a reuse flag for this 
function, will complicate the method.
   Maybe we could add a method specifically for the cache. Or you have a better 
idea?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to