HuangXingBo commented on a change in pull request #14800:
URL: https://github.com/apache/flink/pull/14800#discussion_r590151026
##########
File path: flink-python/pyflink/fn_execution/state_impl.py
##########
@@ -798,6 +857,11 @@ def __init__(self,
state_handler, map_state_read_cache_size)
from pyflink.fn_execution.coders import FlattenRowCoder
self._key_coder_impl =
FlattenRowCoder(key_coder._field_coders).get_impl()
+ self.window_coder = window_coder
Review comment:
Yes. This should actually be added in the follow-up PR, I will delete it
first.
##########
File path: flink-python/pyflink/fn_execution/state_impl.py
##########
@@ -798,6 +857,11 @@ def __init__(self,
state_handler, map_state_read_cache_size)
from pyflink.fn_execution.coders import FlattenRowCoder
self._key_coder_impl =
FlattenRowCoder(key_coder._field_coders).get_impl()
+ self.window_coder = window_coder
+ if window_coder:
Review comment:
Make senses.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
