HuangXingBo commented on a change in pull request #14800:
URL: https://github.com/apache/flink/pull/14800#discussion_r590152449
##########
File path: flink-python/pyflink/fn_execution/state_impl.py
##########
@@ -959,7 +1028,8 @@ def clear_cached_iterators(self):
@staticmethod
def commit_internal_state(internal_state):
- internal_state.commit()
+ if internal_state is not None:
+ internal_state.commit()
Review comment:
Yes, although `None` will not affect the execution of the following
code, but adding the logic of `else return` can be cleaner
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
