XComp commented on a change in pull request #15049:
URL: https://github.com/apache/flink/pull/15049#discussion_r590490207
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobExceptionsInfo.java
##########
@@ -70,14 +80,32 @@ public boolean equals(Object o) {
}
JobExceptionsInfo that = (JobExceptionsInfo) o;
return truncated == that.truncated
+ && Objects.equals(rootExceptionName, that.rootExceptionName)
&& Objects.equals(rootException, that.rootException)
&& Objects.equals(rootTimestamp, that.rootTimestamp)
&& Objects.equals(allExceptions, that.allExceptions);
}
@Override
public int hashCode() {
- return Objects.hash(rootException, rootTimestamp, allExceptions,
truncated);
+ return Objects.hash(
+ rootExceptionName, rootException, rootTimestamp,
allExceptions, truncated);
+ }
+
+ @Override
+ public String toString() {
+ return toStringHelper(this)
Review comment:
To be honest, that is the generated version of Intellij. I considered it
to be better than the `StringBuilder` or String concatenation approaches. But I
overlooked the `StringJoiner` approach which is usable in Java8 and uses native
Java code. I switched to that version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
