rkhachatryan commented on a change in pull request #15146:
URL: https://github.com/apache/flink/pull/15146#discussion_r592457263
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/checkpointing/AlternatingController.java
##########
@@ -58,7 +70,11 @@ public void barrierAnnouncement(
throws IOException {
if (lastSeenBarrier < announcedBarrier.getId()) {
lastSeenBarrier = announcedBarrier.getId();
- firstBarrierArrivalTime = getArrivalTime(announcedBarrier);
+ lastBarrierArrivalTime = getArrivalTime(announcedBarrier);
+ if (announcedBarrier.getCheckpointOptions().isTimeoutable()
+ && activeController == alignedController) {
+ scheduleAnnouncementTimeout(channelInfo, announcedBarrier,
sequenceNumber);
Review comment:
I think we should also take into account whether we are going to time
out the checkpoint passively just a few lines below.
One option would be to store some flag in this branch, but move
`scheduleAnnouncementTimeout` to the end of the method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
