rkhachatryan commented on a change in pull request #15146:
URL: https://github.com/apache/flink/pull/15146#discussion_r592488985
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/checkpointing/AlternatingController.java
##########
@@ -35,15 +39,23 @@
public class AlternatingController implements
CheckpointBarrierBehaviourController {
private final AlignedController alignedController;
private final UnalignedController unalignedController;
+ private final DelayedActionRegistration delayedActionRegistration;
+ private final Clock clock;
private CheckpointBarrierBehaviourController activeController;
- private long firstBarrierArrivalTime = Long.MAX_VALUE;
+ private long lastBarrierArrivalTime = Long.MAX_VALUE;
Review comment:
The meaning of this variable is: arrival time of the first barrier of
the last seen checkpoint :)
So both old `firstBarrierArrivalTime` and new `lastBarrierArrivalTime` don't
reflect it fully.
But to me, the old name is less confusing.
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
