fsk119 commented on pull request #15197: URL: https://github.com/apache/flink/pull/15197#issuecomment-800243481
The PR is mainly designed for compatibility between `ExecutionEntry` and `Configuration`. However, it does introduce some incompatibility. I think the incompatibility is from 2 parts. - Some entries is not supported, e.g. `execution.time-characteristic` - The default value for option and entry may be different, e.g. the default value for `execution.restart-strategy.attempts` is Integer.MAX_VALUE but the default value for `restart-strategy.fixed-delay.attempts` is 1. The reason why I decide to not supprot `execution.time-characteristic` : - The value of `execution.time-characteristic` is different from `StreamPipelineOptions.TIME_CHARACTERISTIC` - `TimeCharacteristic` is also a deprecated class. The main reason to drive me to the conclusion that ignore the incompatibility is users will set the value for restart strategy option in general in production environment... If we really needs completely compatibility, I think it needs more work to be done... Hope my feedback can reduce some comments... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
