zentol commented on a change in pull request #15262:
URL: https://github.com/apache/flink/pull/15262#discussion_r597469924



##########
File path: 
flink-clients/src/test/java/org/apache/flink/client/program/PerJobMiniClusterFactoryTest.java
##########
@@ -190,6 +190,7 @@ private static JobGraph getNoopJobGraph() {
     private static JobGraph getCancellableJobGraph() {
         JobVertex jobVertex = new JobVertex("jobVertex");
         jobVertex.setInvokableClass(MyCancellableInvokable.class);
+        jobVertex.setParallelism(1);

Review comment:
       The downside though is that you need to touch _every single relevant 
test_, whereas the `JobGraphBuilder` approach would cover most(all?) of them.
   FLINK-21866 shows yet another test that fails for the same reason.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to