rmetzger commented on a change in pull request #15262:
URL: https://github.com/apache/flink/pull/15262#discussion_r598505894
##########
File path:
flink-clients/src/test/java/org/apache/flink/client/program/PerJobMiniClusterFactoryTest.java
##########
@@ -190,6 +190,7 @@ private static JobGraph getNoopJobGraph() {
private static JobGraph getCancellableJobGraph() {
JobVertex jobVertex = new JobVertex("jobVertex");
jobVertex.setInvokableClass(MyCancellableInvokable.class);
+ jobVertex.setParallelism(1);
Review comment:
I'm always careful changing default parallelisms in production code, as
there could be unforeseen effects (incompatible savepoints across versions,
parallelism changes after upgrading to Flink 1.13 in scenarios where users rely
on this somehow).
From this PR it seems that the number of tests that violate the contract
seems reasonably small to just fix the tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
