rkhachatryan commented on a change in pull request #15204:
URL: https://github.com/apache/flink/pull/15204#discussion_r597632959
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/state/CheckpointableKeyedStateBackend.java
##########
@@ -45,5 +46,6 @@
* write out a savepoint in the common/unified format.
*/
@Nonnull
- SavepointResources<K> savepoint() throws Exception;
+ SavepointResources<K> savepoint(long checkpointId, CheckpointOptions
checkpointOptions)
Review comment:
Creating snapshot for checkpoint and for savepoint differently would
complicate `HeapSnapshotResources`.
OTH, both these arguments seem relevant to both checkpoint and savepoints.
What is your concern about these arguments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
