[
https://issues.apache.org/jira/browse/FLINK-3735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15239008#comment-15239008
]
ASF GitHub Bot commented on FLINK-3735:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1874#discussion_r59524034
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/api/table/plan/rules/dataSet/DataSetUnionRule.scala
---
@@ -32,6 +32,13 @@ class DataSetUnionRule
"FlinkUnionRule")
{
+ /**
+ * Only translate UNION ALL
+ */
+ override def matches(call: RelOptRuleCall): Boolean = {
+ val union: LogicalUnion = call.rel(0).asInstanceOf[LogicalUnion]
+ union.all
+ }
def convert(rel: RelNode): RelNode = {
--- End diff --
Add a newline between the methods. I also looks like the indention of
{{convert}} is a bit messed up. Can you correct that as well?
> Embedded SQL union should fail during translation
> -------------------------------------------------
>
> Key: FLINK-3735
> URL: https://issues.apache.org/jira/browse/FLINK-3735
> Project: Flink
> Issue Type: Bug
> Components: Table API
> Affects Versions: 1.1.0
> Reporter: Vasia Kalavri
> Assignee: Vasia Kalavri
>
> The Table API currently only supports union all and embedded SQL queries
> translate both union and union all to union all. We should only generate a
> valid plan for union all.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
