kezhuw commented on a change in pull request #15273:
URL: https://github.com/apache/flink/pull/15273#discussion_r599278435



##########
File path: 
flink-core/src/test/java/org/apache/flink/core/memory/OffHeapUnsafeMemorySegmentTest.java
##########
@@ -58,4 +61,31 @@ public void testCallCleanerOnFree() {
                 .free();
         assertTrue(cleanerFuture.isDone());
     }
+
+    @Test
+    public void testCallCleanerOnceOnConcurrentFree() throws 
InterruptedException {
+        final AtomicInteger counter = new AtomicInteger(0);

Review comment:
       Ideally, it would be better to test all paths in codes. But I also could 
not give a less intrusive solution to this. So, I am just fine with current 
situation.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to