kezhuw commented on a change in pull request #15273:
URL: https://github.com/apache/flink/pull/15273#discussion_r599712183
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/memory/MemoryManager.java
##########
@@ -346,9 +346,6 @@ private MemorySegment releaseSegmentsForOwnerUntilNextOwner(
while (segmentsIterator.hasNext()) {
MemorySegment segment = segmentsIterator.next();
try {
- if (segment == null || segment.isFreed()) {
Review comment:
I think the follow up should be either dropping null-tolerance or adding
test case to guard null-tolerance. The implementation is carefully designed(I
guess so) while there is no test to assert on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
