tillrohrmann commented on a change in pull request #14945:
URL: https://github.com/apache/flink/pull/14945#discussion_r602324877
##########
File path:
flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/pom.xml
##########
@@ -45,6 +45,7 @@ under the License.
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<flink.version>@project.version@</flink.version>
+ <target.java.version>@target.java.version@</target.java.version>
Review comment:
Shouldn't we also update `maven-compiler-plugin` in this `pom.xml` to
use `${target.java.version}`?
##########
File path:
flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/pom.xml
##########
@@ -45,6 +45,7 @@ under the License.
<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<flink.version>@project.version@</flink.version>
+ <target.java.version>@target.java.version@</target.java.version>
Review comment:
Maybe also update this field in the `flink-quickstart-java` module. I
think there it is fixed to `1.8`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
