kezhuw commented on a change in pull request #15397:
URL: https://github.com/apache/flink/pull/15397#discussion_r602894410
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SplitAssignmentTracker.java
##########
@@ -71,7 +68,8 @@ public void snapshotState(
// Include the uncheckpointed assignments to the snapshot.
assignmentsByCheckpointId.put(checkpointId, uncheckpointedAssignments);
uncheckpointedAssignments = new HashMap<>();
- writeAssignmentsByCheckpointId(assignmentsByCheckpointId,
splitSerializer, out);
Review comment:
I guess this is a breaking change. Old version will fails in restoring
(EOFException ?). How about a forward compatible change ? It should similar to
how FLINK-21452 do in
[pr-14994](https://github.com/apache/flink/pull/14994/files#diff-9144631bff9092280da424a52db7a60d2e0f47e82b0c55ccbdc93ac29614d75cL291).
I known Flink does not support downgrade, but I think it is might be a good
for this minor change to not breaking anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
