afedulov commented on a change in pull request #15054:
URL: https://github.com/apache/flink/pull/15054#discussion_r602935625
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManagerGateway.java
##########
@@ -266,4 +267,12 @@ void heartbeatFromTaskManager(
*/
CompletableFuture<ThreadDumpInfo> requestThreadDump(
ResourceID taskManagerId, @RpcTimeout Time timeout);
+
+ /**
+ * Requests the {@link TaskExecutorGateway}.
+ *
+ * @param taskManagerId identifying the {@link TaskExecutor}.
+ * @return Future containing the task executor gateway.
+ */
+ CompletableFuture<TaskExecutorGateway>
requestTaskExecutorGateway(ResourceID taskManagerId);
Review comment:
Flame Graphs component needs to be able to send requests to the
`TaskExecutors` that are responsible for running the subtasks of the vertex
selected in the UI. What would be the alternative?
P.S.: it has been an explicit request from Till to avoid adding non-core
functionality to the `JobManagerSharedServices`, the way the old backpressure
sampler was implemented, and rather rely on the `ArchivedExecutionGraph` which
is already available to the `WebMonitorEndpoint`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
