afedulov commented on a change in pull request #15054:
URL: https://github.com/apache/flink/pull/15054#discussion_r602932126
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/WebOptions.java
##########
@@ -156,6 +156,48 @@
.withDeprecatedKeys("jobmanager.web.backpressure.delay-between-samples")
.withDescription("This config option is no longer used");
+ /** Time, in milliseconds, after which cached stats are cleaned up if not
accessed. */
+ public static final ConfigOption<Integer> FLAMEGRAPH_CLEANUP_INTERVAL =
Review comment:
Got it, thanks. I'll switch to duration. Are there any preferences in
which format to pass time parameters internally after they are parsed from the
configuration? I see that, for instance, `START_WORKER_RETRY_INTERVAL` is
explicitly converted into `org.apache.flink.api.common.time.Time`. I have a
choice to
1. keep everything in Duration and call `toMillis()` every time when they
are used
2. convert everything into long right after the extraction from the config
3. convert everything into Flink's Time class
What do you prefer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
