AHeise commented on a change in pull request #15436:
URL: https://github.com/apache/flink/pull/15436#discussion_r604401851
##########
File path:
flink-core/src/main/java/org/apache/flink/api/common/io/FileInputFormat.java
##########
@@ -235,7 +236,12 @@ public FileInputFormat() {}
protected FileInputFormat(Path filePath) {
if (filePath != null) {
- setFilePath(filePath);
+ // support glob
+ setFilePath(filePath.getParent());
+ setFilesFilter(
+ new GlobFilePathFilter(
+ Collections.singletonList(filePath.getPath()),
+ Collections.emptyList()));
Review comment:
Does it make sense to check if there is a `*` and only use the glob code
then? Note sure if there is a noticeable performance penalty (I guess not since
that is probably only setup code).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
