zentol edited a comment on pull request #15436: URL: https://github.com/apache/flink/pull/15436#issuecomment-810644692
Echoing my thoughts from the JIRA: > I don't think it is a good idea to now try to retrofit this into the Path or FileInputFormat. It changes behaviors in subtle ways that could break existing setups. For example, with the proposed changes more file infos are pulled from the filesystems [because we now list files in the parent directory; imaging the original path was /data, now you're listing the contents of root; this can both impact performance and cause failures due to lack of permissions]. More paths are passed to the filter which may break existing logic. Subclasses may be surprised that the set filepath is different, or that a filter was set. It is also questionable given that glob patterns may contain wildcards in any part of the path; and filesystems may or may not properly support this. Considering that this isn't providing any new functionality I don't think we should go forward with this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
