[
https://issues.apache.org/jira/browse/FLINK-3773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15244559#comment-15244559
]
ASF GitHub Bot commented on FLINK-3773:
---------------------------------------
GitHub user samaitra opened a pull request:
https://github.com/apache/flink/pull/1902
FLINK-3773 Scanners are left unclosed in SqlExplainTest
Thanks for contributing to Apache Flink. Before you open your pull request,
please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your
pull request. For more information and/or questions please refer to the [How To
Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful
description of your changes.
- [ ] General
- The pull request references the related JIRA issue
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis
build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/samaitra/flink FLINK-3773
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1902.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1902
----
commit fca1fb2fb6fcd5990aa26f7e0da88e20c5090c71
Author: samaitra <[email protected]>
Date: 2016-04-17T06:54:50Z
FLINK-3773 Scanners are left unclosed in SqlExplainTest
----
> Scanners are left unclosed in SqlExplainTest
> --------------------------------------------
>
> Key: FLINK-3773
> URL: https://issues.apache.org/jira/browse/FLINK-3773
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Priority: Minor
>
> e.g.
> {code}
> String source = new Scanner(new File(testFilePath +
> "../../src/test/scala/resources/testFilter0.out"))
> {code}
> Scanner implements AutoCloseable.
> Using try-with-resources would be a good pattern for closing the Scanners.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
