[ 
https://issues.apache.org/jira/browse/FLINK-3777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15247406#comment-15247406
 ] 

Flavio Pompermaier edited comment on FLINK-3777 at 4/19/16 10:19 AM:
---------------------------------------------------------------------

I issued a PR yesterday (https://github.com/apache/flink/pull/1903) that should 
fix this issue. Maybe it could worth to also add a {{closeOutputFormat()}} for 
{{OutputFormat}} too?


was (Author: f.pompermaier):
I issued a PR yesterday (https://github.com/apache/flink/pull/1903) that should 
fix this issue. Maybe it could worth to also add a {{closeOutputFormat()}} for 
{{OutputFormat}}?

> Add open and close methods to manage IF lifecycle
> -------------------------------------------------
>
>                 Key: FLINK-3777
>                 URL: https://issues.apache.org/jira/browse/FLINK-3777
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.0.1
>            Reporter: Flavio Pompermaier
>            Assignee: Flavio Pompermaier
>              Labels: inputformat, lifecycle
>
> At the moment the opening and closing of an inputFormat are not managed, 
> although open() could be (improperly IMHO) simulated by configure().
> This limits the possibility to reuse expensive resources (like database 
> connections) and manage their release. 
> Probably the best option would be to add 2 methods (i.e. openInputformat() 
> and closeInputFormat() ) to RichInputFormat*
> * NOTE: the best option from a "semantic" point of view would be to rename 
> the current open() and close() to openSplit() and closeSplit() respectively 
> while using open() and close() methods for the IF lifecycle management, but 
> this would cause a backward compatibility issue...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to