[
https://issues.apache.org/jira/browse/FLINK-3777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15245430#comment-15245430
]
Flavio Pompermaier edited comment on FLINK-3777 at 4/18/16 10:24 AM:
---------------------------------------------------------------------
Ok. I could issue a PR for this if you don't mind. I'll leave everything as it
is now except for the add of {{openInputFormat()}} (and integrate its call
where necessary).
Do you prefer to add it to {{RichInputFormat}} or {{ InputFormat}}?
Once merged the PR, I could add a JIRA with target Flink 2.0 in order to
remember to better rename those methods. Is it ok?
was (Author: f.pompermaier):
Ok. I could issue a PR for this if you don't mind. I'll leave everything as it
is now except for the add of {{openInputFormat()}} (and integrate its call
where necessary).
Do you prefer to add it to {{RichInputFormat}} or{{ InputFormat}}?
Once merged the PR, I could add a JIRA with target Flink 2.0 in order to
remember to better rename those methods. Is it ok?
> Add open and close methods to manage IF lifecycle
> -------------------------------------------------
>
> Key: FLINK-3777
> URL: https://issues.apache.org/jira/browse/FLINK-3777
> Project: Flink
> Issue Type: Sub-task
> Components: Core
> Affects Versions: 1.0.1
> Reporter: Flavio Pompermaier
> Labels: inputformat, lifecycle
>
> At the moment the opening and closing of an inputFormat are not managed,
> although open() could be (improperly IMHO) simulated by configure().
> This limits the possibility to reuse expensive resources (like database
> connections) and manage their release.
> Probably the best option would be to add 2 methods (i.e. openInputformat()
> and closeInputFormat() ) to RichInputFormat*
> * NOTE: the best option from a "semantic" point of view would be to rename
> the current open() and close() to openSplit() and closeSplit() respectively
> while using open() and close() methods for the IF lifecycle management, but
> this would cause a backward compatibility issue...
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
