JingsongLi commented on a change in pull request #15489:
URL: https://github.com/apache/flink/pull/15489#discussion_r608586451
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/planner/expressions/ScalarFunctionsTest.scala
##########
@@ -4061,4 +4061,76 @@ class ScalarFunctionsTest extends ScalarTypesTestBase {
"f55=f57",
"true")
}
+
+ @Test
+ def testStringFunctionAndExpressionResultType(): Unit = {
+ // this test is to check if the `resultType` of the `GeneratedExpression`
+ // of these string functions match their definition in
`FlinkSqlOperatorTable`
+ // see FLINK-22106
Review comment:
I still don't think we should leave the JIRA number here. Leaving the
JIRA number in the code should be because the JIRA has not been resolved.
Here you should put the information in JIRA clearly here instead of JIRA
number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
