kezhuw commented on a change in pull request #15557:
URL: https://github.com/apache/flink/pull/15557#discussion_r612544962
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/OperatorCoordinator.java
##########
@@ -202,8 +202,7 @@ default void notifyCheckpointAborted(long checkpointId) {}
* target TaskManager. The future is completed exceptionally if the
event cannot be sent.
* That includes situations where the target task is not running.
*/
- CompletableFuture<Acknowledge> sendEvent(OperatorEvent evt, int
targetSubtask)
- throws TaskNotRunningException;
+ CompletableFuture<Acknowledge> sendEvent(OperatorEvent evt, int
targetSubtask);
Review comment:
> Callers can mostly decide to ignore the result of the future, if they
handle the `notifyTaskFaile()` call.
> a dated SubtaskGateway could throw TaskNotRunningException after subtask
failed/reset for earlier failing possible active activities.
With `subtaskReady` and `SubtaskGateway`, even silence should not hurt
correctness. I think all should work. But given that future is most likely
ignored, I am a bit prefer to call stack exception. It could be more helpful in
diagnostics of buggy code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
