kezhuw commented on a change in pull request #15557:
URL: https://github.com/apache/flink/pull/15557#discussion_r612614499
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/operators/coordination/OperatorCoordinator.java
##########
@@ -202,8 +202,7 @@ default void notifyCheckpointAborted(long checkpointId) {}
* target TaskManager. The future is completed exceptionally if the
event cannot be sent.
* That includes situations where the target task is not running.
*/
- CompletableFuture<Acknowledge> sendEvent(OperatorEvent evt, int
targetSubtask)
- throws TaskNotRunningException;
+ CompletableFuture<Acknowledge> sendEvent(OperatorEvent evt, int
targetSubtask);
Review comment:
Hmmm, I see value of "received" future. To solely solve FLINK-21996(eg.
source split assignment exactly-once), `SourceCoordinator` could take the
received future into account for specific events during checkpointing. I am not
sure how next pr will look like. But I think this(my assumed approach) actually
means that `OperatorCoordinator` authors should also take exactly-once into
account if they want this.
Still not sure how this could be helpful for custom source events and no
source task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
