Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1903#issuecomment-212483482
Thanks for this PR @fpompermaier.
We need to check all places where `InputFormat.configure()` is called to
ensure that we free resources as promised in the JavaDocs of
`RichInputFormat.closeInputFormat()`. I found a few more spots where we need to
call `closeInputFormat()` if the IF is a `RichInputFormat`.
- ReplicatingInputFormat which is a wrapper for other input formats.
- DataSourceNode.computeOperatorSpecificDefaultEstimates() which tries to
obtain some input statistics and initializes the input format with
`configure()`.
- `InputFormatVertex.initializeOnMaster()` calls `configure()` as well.
It would also be good to add a test that the closeInputFormat() method is
actually called.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
